[ 
https://issues.apache.org/jira/browse/SOLR-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13764330#comment-13764330
 ] 

Joel Bernstein edited comment on SOLR-5230 at 9/11/13 2:05 PM:
---------------------------------------------------------------

After reviewing the code, I believe the finish() method needs to be called in 
both phases. It looks like in Phase1 the group heads are collected and in 
phase2 the sub-documents are collected. In both situations the postfilter needs 
to be applied and finish called.
                
      was (Author: joel.bernstein):
    After reviewing the code, I believe the finish() method needs to be called 
in both phases. It looks like in Phase1 the group heads are collected and in 
phase2 the sub-documents are collected. In both situation the postfilter needs 
to be applied and finish called.
                  
> Call DelegatingCollector.finish() during grouping
> -------------------------------------------------
>
>                 Key: SOLR-5230
>                 URL: https://issues.apache.org/jira/browse/SOLR-5230
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>    Affects Versions: 4.4
>            Reporter: Joel Bernstein
>            Priority: Minor
>             Fix For: 4.5, 5.0
>
>         Attachments: SOLR-5230.patch
>
>
> This is an add-on to SOLR-5020 to call the new DelegatingCollector.finish() 
> method from inside the grouping flow. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to