[
https://issues.apache.org/jira/browse/SOLR-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated SOLR-4914:
--------------------------------
Attachment: SOLR-4914.patch
Final patch. All tests pass.
There are a couple of bits here which could do with following up:
1) CoreAdminHandler.handleCreateAction is doing a bunch of stuff that really
ought to be moved inside CoreContainer.
2) I'm a bit concerned by what will happen if somebody creates two cores using
the same instance dir when in core discovery mode - the second core's
core.properties file will overwrite the first. This is only an issue in core
discovery mode, though, as storing core definitions in solr.xml can deal with
this fine.
> Factor out core discovery and persistence logic
> -----------------------------------------------
>
> Key: SOLR-4914
> URL: https://issues.apache.org/jira/browse/SOLR-4914
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 5.0
> Reporter: Erick Erickson
> Assignee: Alan Woodward
> Attachments: SOLR-4914.patch, SOLR-4914.patch, SOLR-4914.patch,
> SOLR-4914.patch, SOLR-4914.patch, SOLR-4914.patch
>
>
> Alan Woodward has done some work to refactor how core persistence works that
> we should work on going forward that I want to separate from a shorter-term
> tactical problem (See SOLR-4910).
> I'm attaching Alan's patch to this JIRA and we'll carry it forward separately
> from 4910.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
