[
https://issues.apache.org/jira/browse/SOLR-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13701173#comment-13701173
]
Erick Erickson commented on SOLR-4948:
--------------------------------------
[~romseygeek] Uwe uncovered a problem with this patch, possibly accounting for
the PermGen errors we've seen lately in the tests. Plus, I have some fixes I
want to get into 4.4. So my vote is to go ahead and merge this into 4.x and
we'll fix anything that crops up.
If Uwe backports stuff then merging the changes for this JIRA and his changes
get complicated. Maybe it's time to just bite the bullet?
> Tidy up CoreContainer construction logic
> ----------------------------------------
>
> Key: SOLR-4948
> URL: https://issues.apache.org/jira/browse/SOLR-4948
> Project: Solr
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Minor
> Attachments: SOLR-4948.patch, SOLR-4948.patch, SOLR-4948.patch,
> SOLR-4948.patch, SOLR-4948.patch, SOLR-4948.patch, SOLR-4948.patch
>
>
> While writing tests for SOLR-4914, I discovered that it's *really difficult*
> to create a CoreContainer. There are a bunch of constructors which
> initialise different things, one (but only one!) of which also loads all the
> cores. Then you have the Initializer object, which basically does the same
> thing. Sort of. And then the TestHarness doesn't actually use
> CoreContainer, but an anonymous subclass of CoreContainer which has it's own
> initialisation logic. It would be nice to clean this up!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
