[
https://issues.apache.org/jira/browse/SOLR-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated SOLR-4948:
--------------------------------
Attachment: SOLR-4948.patch
Latest patch. I still have two test failures in
SolrCoreCheckLockOnStartupTest, which I think is due to the old TestHarness not
using the normal load() logic and just creating a core on its own.
The tests create an IndexWriter on a directory, and then try to open a new
SolrCore over the same instance dir. This should fail, but it seems that the
default DirectoryFactory notices that there's already an index there, and
creates a new index_temp directory to hold the Core's index. Which means no
exceptions get thrown, and the test passes. Will try and work out which
DirectoryFactory was used before...
> Tidy up CoreContainer construction logic
> ----------------------------------------
>
> Key: SOLR-4948
> URL: https://issues.apache.org/jira/browse/SOLR-4948
> Project: Solr
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Minor
> Attachments: SOLR-4948.patch, SOLR-4948.patch
>
>
> While writing tests for SOLR-4914, I discovered that it's *really difficult*
> to create a CoreContainer. There are a bunch of constructors which
> initialise different things, one (but only one!) of which also loads all the
> cores. Then you have the Initializer object, which basically does the same
> thing. Sort of. And then the TestHarness doesn't actually use
> CoreContainer, but an anonymous subclass of CoreContainer which has it's own
> initialisation logic. It would be nice to clean this up!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
