[ 
https://issues.apache.org/jira/browse/LUCENE-5030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13689269#comment-13689269
 ] 

Michael McCandless commented on LUCENE-5030:
--------------------------------------------

Hmm can you post the full output of the benchmark?  It measures different 
things in each test case.

Given this, I guess we should make a separate fuzzy suggester class (that 
measures edit distance in Unicode code point space)?  Or make it a boolean 
option on the current class ...

Can you also post your last patch (cutting over to INFO_SEP/2 for the stolen 
chars)?
                
> FuzzySuggester has to operate FSTs of Unicode-letters, not UTF-8, to work 
> correctly for 1-byte (like English) and multi-byte (non-Latin) letters
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-5030
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5030
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 4.3
>            Reporter: Artem Lukanin
>         Attachments: nonlatin_fuzzySuggester1.patch, 
> nonlatin_fuzzySuggester2.patch, nonlatin_fuzzySuggester3.patch, 
> nonlatin_fuzzySuggester4.patch, nonlatin_fuzzySuggester.patch, 
> nonlatin_fuzzySuggester.patch, nonlatin_fuzzySuggester.patch, 
> run-suggest-benchmark.patch
>
>
> There is a limitation in the current FuzzySuggester implementation: it 
> computes edits in UTF-8 space instead of Unicode character (code point) 
> space. 
> This should be fixable: we'd need to fix TokenStreamToAutomaton to work in 
> Unicode character space, then fix FuzzySuggester to do the same steps that 
> FuzzyQuery does: do the LevN expansion in Unicode character space, then 
> convert that automaton to UTF-8, then intersect with the suggest FST.
> See the discussion here: 
> http://lucene.472066.n3.nabble.com/minFuzzyLength-in-FuzzySuggester-behaves-differently-for-English-and-Russian-td4067018.html#none

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to