[
https://issues.apache.org/jira/browse/SOLR-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated SOLR-4914:
--------------------------------
Attachment: SOLR-4914.patch
Patch with my latest status. It won't compile yet, as I haven't updated all
tests to reflect the new API. Will work on that next.
This combines core discovery and persistence into the CoresListPersistor
interface. All persistence logic is removed from CoreContainer and ConfigSolr
and put into the two implementing classes of CorePropertiesPersistor and
SolrXMLPersistor.
CoreDescriptor is tidied up a bit, and made effectively immutable (would be
nicer to make it really immutable, maybe with an ImmutableProperties class).
The original pre-substitution parameters are stored as well as the values after
substitution, which makes persistence a lot easier (you just read from the
original values).
Solr.xml persistence is also made a lot simpler, by just storing everything
around the <cores/> tag as a flat string, and only updating the <core> tags.
So you don't need to remember to add new solr.xml parameters to core
persistence logic any more, and things like comments will be preserved.
This is a pretty big patch, and there's still a fair amount to do, but I'd be
grateful for some preliminary reviews. I think it simplifies the whole core
discovery/persistence logic a lot.
> Refactor core persistence to reflect deprecating the <core> tags in solr.xml
> ----------------------------------------------------------------------------
>
> Key: SOLR-4914
> URL: https://issues.apache.org/jira/browse/SOLR-4914
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 5.0
> Reporter: Erick Erickson
> Attachments: SOLR-4914.patch, SOLR-4914.patch
>
>
> Alan Woodward has done some work to refactor how core persistence works that
> we should work on going forward that I want to separate from a shorter-term
> tactical problem (See SOLR-4910).
> I'm attaching Alan's patch to this JIRA and we'll carry it forward separately
> from 4910.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
