[ 
https://issues.apache.org/jira/browse/LUCENE-4995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655364#comment-13655364
 ] 

Adrien Grand commented on LUCENE-4995:
--------------------------------------

bq. Are we sure this is the right thing to do?

I have no idea at all. On the one hand, it looks reasonable to me to have a 
reusable per-thread buffer to handle decompression, but on the other hand, it 
makes me unhappy that its size is unbounded: if an index has a few 1M documents 
on S segments and T threads, the JVM will have to reserve S*T*1M of heap just 
to be able to handle decompression.
                
> Remove the strong reference of CompressingStoredFieldsReader on the 
> decompression buffer
> ----------------------------------------------------------------------------------------
>
>                 Key: LUCENE-4995
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4995
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>         Attachments: LUCENE-4995.patch
>
>
> CompressingStoredFieldsReader has a strong reference on the buffer it uses 
> for decompression. Although it makes the reader able to reuse this buffer, 
> this can trigger high memory usage in case some documents are very large. 
> Creating this buffer on demand would help give memory back to the JVM.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to