[ 
https://issues.apache.org/jira/browse/LUCENE-4975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649631#comment-13649631
 ] 

Shai Erera commented on LUCENE-4975:
------------------------------------

I've been wondering about that too, but chose to keep the facet replication 
code under replicator for few reasons:

* A Revision contains files from multiple sources, and the taxonomy index is 
partly responsible for that. And ReplicationClient respects that -- so I guess 
it's not entirely true that the Replicator is unaware of taxonomy (even though 
it would still work if I pulled the taxonomy stuff out of it).

* I think it makes less sense to require lucene-replicator.jar for every 
faceted search app which makes use of lucene-facet.jar. The key reason is that 
replicator requires few additional jars such as httpclient, httpcore, jetty, 
servlet-api. Requiring lucene-facet.jar seems less painful to me, than 
requiring every faceted search app out there to include all these jars even if 
it doesn't want to do replication.

* I like to keep things local to the module. There are many similarities 
between IndexAndTaxoRevision to IndexRevision (likewise for their handlers and 
tests). Therefore whenever I made change to one, I knew I should go make a 
similar change to the other.

All in all, I guess arguments can be made both ways, but I prefer for the now 
to keep things local to the replicator module. Even in the future, I would 
imagine that if we added support for replicating a suggester files, then it 
would make sense to put a dependency between replicator and suggester, rather 
than the other way around.
                
> Add Replication module to Lucene
> --------------------------------
>
>                 Key: LUCENE-4975
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4975
>             Project: Lucene - Core
>          Issue Type: New Feature
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>         Attachments: LUCENE-4975.patch, LUCENE-4975.patch, LUCENE-4975.patch, 
> LUCENE-4975.patch
>
>
> I wrote a replication module which I think will be useful to Lucene users who 
> want to replicate their indexes for e.g high-availability, taking hot backups 
> etc.
> I will upload a patch soon where I'll describe in general how it works.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to