[
https://issues.apache.org/jira/browse/SOLR-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-3972:
---------------------------
Attachment: SOLR-3972.patch
bq. This removes the admin-extra functionality from the admin UI.
Upayavira: as mentioned in my previous comment, the idea behind the changes in
SOLR-4019 was to eliminate these exceptions from the log, that patch just
didn't address all of the code paths in ShowFileRequestHandler. While your
patch completely removes the admin-extra UI feature, and eliminates the
exceptions when using the UI -- it doesn't address the underlying issue:
ShowFileRequestHandler shouldn't log a big loud ugly stack trace for the
understandable error of a 404 "file not found"
This new patch fixes the remaining code paths in ShowFileREquestHandler to
"return" the 404 exception instead of throwing it and includes tests for this
-- which should be done regardless of anything else. It also leaves the
admin-extra functionality in place, since it's no longer noisy if the files 404.
Does any one actually object to leaving this admin-extras functionality in
place with this fix?
> Missing admin-extra files result in SEVERE log entries with giant stacktrace
> ----------------------------------------------------------------------------
>
> Key: SOLR-3972
> URL: https://issues.apache.org/jira/browse/SOLR-3972
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Affects Versions: 4.0, 4.1
> Environment: Linux bigindy5 2.6.32-279.9.1.el6.centos.plus.x86_64 #1
> SMP Wed Sep 26 03:52:55 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux
> java version "1.7.0_07"
> Java(TM) SE Runtime Environment (build 1.7.0_07-b10)
> Java HotSpot(TM) 64-Bit Server VM (build 23.3-b01, mixed mode)
> Reporter: Shawn Heisey
> Assignee: Hoss Man
> Fix For: 4.1
>
> Attachments: SOLR-3972.patch, SOLR-3972.patch
>
>
> Missing admin-extra files result in SEVERE log entries with giant stacktrace.
> If a log entry is warranted at all, it should just be a one-line warning.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
