[ 
https://issues.apache.org/jira/browse/LUCENE-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499471#comment-13499471
 ] 

Michael McCandless commented on LUCENE-4271:
--------------------------------------------

I think it's odd to add syntax to Lucene's query parser that does ... nothing?

And it's strange to make Lucene's QP aware of Solr QP's syntax if it cannot do 
anything with it.  It seems like Solr's QP should have this logic instead ...

bq. Since I've opened this issue, I've seen even more people try to use {!foo} 
syntax directly in a lucene query string.

I'm confused: how would this patch help such users?  Ie if they are using 
Lucene's QP this patch doesn't seem to help them ... if users are trying to use 
Solr's syntax with Lucene's query parser, it seems like we should make it 
easier for them to use Solr's query parsers (factor them out)...?

{quote}
Is the intention to mandate the !var syntax too? That seems like a pretty Solr 
specific thing (being able to delegate the parsing to a QParser) but I can 
imagine someone just wanting a map of values, e.g.

\{arg_1=val_1 arg_2=val_2\} word
{quote}

Right: if we added functionality to Lucene's QP that parsed those arg/val's to 
an accessible Map<String,String> ... I think that would be a useful addition?  
I agree we really shouldn't bake in Solr specific syntax into Lucene's QP ...
                
> Solr LocalParams for Lucene Query Parser
> ----------------------------------------
>
>                 Key: LUCENE-4271
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4271
>             Project: Lucene - Core
>          Issue Type: New Feature
>            Reporter: Yonik Seeley
>         Attachments: LUCENE-4271.patch
>
>
> The Lucene QueryParser should implement Solr's LocalParams syntax directly so 
> that instead of
> {code}
> _query_:"{!geodist d=10 p=20.5,30.2}"
> {code}
> one could directly use
> {code}
> {!geodist d=10 p=20.5,30.2}
>  {code}
> references: http://wiki.apache.org/solr/LocalParams

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to