Thanks Mike, I switched to properly populating POMtemplates, and removed the debug printing. Committed to the release branch, branch_4x, and trunk.
I also enabled running the smoke tester under Cygwin again. It passed for me using the 'ant nightly-smoke'-produced fake release. Steve -----Original Message----- From: Michael McCandless [mailto:[email protected]] Sent: Saturday, September 22, 2012 1:10 PM To: [email protected] Subject: Re: svn commit: r1388844 - /lucene/dev/branches/lucene_solr_4_0/dev-tools/scripts/smokeTestRelease.py OK I inverted it :) Hopefully Steve will come to the rescue with the proper fix! Mike McCandless http://blog.mikemccandless.com On Sat, Sep 22, 2012 at 1:07 PM, Uwe Schindler <[email protected]> wrote: > I would invert that check to test for *.xml.template. > > Uwe > > ----- > Uwe Schindler > H.-H.-Meier-Allee 63, D-28213 Bremen > http://www.thetaphi.de > eMail: [email protected] > > >> -----Original Message----- >> From: [email protected] [mailto:[email protected]] >> Sent: Saturday, September 22, 2012 7:04 PM >> To: [email protected] >> Subject: svn commit: r1388844 - >> /lucene/dev/branches/lucene_solr_4_0/dev- >> tools/scripts/smokeTestRelease.py >> >> Author: mikemccand >> Date: Sat Sep 22 17:04:14 2012 >> New Revision: 1388844 >> >> URL: http://svn.apache.org/viewvc?rev=1388844&view=rev >> Log: >> hack: skip .properties from POM checking; really we need to figure >> out why .properties is in POMtemplates[project] to begin with... >> >> Modified: >> lucene/dev/branches/lucene_solr_4_0/dev- >> tools/scripts/smokeTestRelease.py >> >> Modified: lucene/dev/branches/lucene_solr_4_0/dev- >> tools/scripts/smokeTestRelease.py >> URL: >> http://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_4_0/dev- >> tools/scripts/smokeTestRelease.py?rev=1388844&r1=1388843&r2=1388844&v >> i >> ew=diff >> ================================================================ >> ============== >> --- lucene/dev/branches/lucene_solr_4_0/dev- >> tools/scripts/smokeTestRelease.py (original) >> +++ lucene/dev/branches/lucene_solr_4_0/dev- >> tools/scripts/smokeTestRelease.py Sat Sep 22 17:04:14 2012 @@ -982,6 >> +982,8 @@ def verifyArtifactPerPOMtemplate(POMtemp >> xpathSkipConfiguration = '{0}configuration/{0}skip'.format(namespace) >> for project in ('lucene', 'solr'): >> for POMtemplate in POMtemplates[project]: >> + if POMtemplate.endswith('.properties'): >> + continue >> print(' Checking POM template %s' % POMtemplate) >> treeRoot = ET.parse(POMtemplate).getroot() >> skipDeploy = False > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] For > additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
