I don't mind but why do we need a specific property (other than Java's default temporary file location property)? Perhaps it'd be better to just use that?
Dawid On Thu, Jun 21, 2012 at 1:08 PM, Simon Willnauer <simon.willna...@googlemail.com> wrote: > hey folks, > > I'd like to control the tempDir used to execute junit tests from the > outside. Any objections to the patch below? > > > diff --git a/lucene/common-build.xml b/lucene/common-build.xml > index 47d5013..2c8f144 100644 > --- a/lucene/common-build.xml > +++ b/lucene/common-build.xml > @@ -95,6 +95,7 @@ > <property name="tests.verbose" value="false"/> > <property name="tests.infostream" value="${tests.verbose}"/> > <property name="tests.heapsize" value="512M"/> > + <property name="tests.tempDir" value="${build.dir}/test"/> > > <!-- Override these in your local properties to your desire. --> > <!-- Show simple class names (no package) in test suites. --> > @@ -705,7 +706,7 @@ > <attribute name="junit.output.dir" default="${junit.output.dir}"/> > <attribute name="junit.classpath" default="junit.classpath"/> > <attribute name="testsDir" default="${build.dir}/classes/test"/> > - <attribute name="tempDir" default="${build.dir}/test"/> > + <attribute name="tempDir" default="${tests.tempDir}"/> > <attribute name="threadNum" default="1"/> > <attribute name="tests.nightly" default="${tests.nightly}"/> > <attribute name="tests.weekly" default="${tests.weekly}"/> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org