[ 
https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280233#comment-13280233
 ] 

Robert Muir commented on LUCENE-4051:
-------------------------------------

javadocs look good: trivial nitpick i noticed some relics in TermVectorsFormat 
such as:   
{noformat}
* <p>Document (.tvd) --&gt; TVDVersion&lt;NumFields, FieldNums,
{noformat}

I think TVDVersion should just say Header (i noticed this for TVF etc too)
                
> Fix File Headers for Lucene40 StoredFields & TermVectors
> --------------------------------------------------------
>
>                 Key: LUCENE-4051
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4051
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: core/codecs
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-4051.patch, LUCENE-4051.patch, LUCENE-4051.patch, 
> LUCENE-4051.patch
>
>
> Currently we still write the "old" file header format in 
> Lucene40StoredFieldFormat & Lucene40TermVectorsFormat. We should cut over to 
> use CodecUtil and reset the versioning before we release Lucene 4.0

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to