Hey all, when we released Lucene 10, the intention was to remove the deprecated IndexSearcher#search(Query, Collector) in favour of the search method that takes a CollectorManager.
The former method is deprecated because it implicitly disables intra-query concurrency even if the searcher has an executor set. We did not remove all the deprecated usages and we let that slip for the Lucene 10 release. There's an open meta issue for the remaining work at https://github.com/apache/lucene/issues/12892, which I recently picked back up, with the help of a kind contributor (gaobinlong - thanks!!!). We are now very close, all the needed PRs are either merged or open waiting for review (3 left to go - one of which I am actively reviewing).Getting reviews has not been easy. While that's acceptable for some recent changes I made, two open PRs really deserve attention because they cover areas I don't know well, increasing the risk of introducing silly bugs. Could the expert in the areas have a look please? I am also good if we close them and come up with alternative approaches, as long as we achieve the removal soon enough, which is long overdue in main. Otherwise, there's the risk that we introduce deprecated usages back, which requires further cleaning up etc. Here are the PRs that I need help with: - join: Replace deprecated search(Query, Collector) with CollectorManager in JoinUtil (https://github.com/apache/lucene/pull/16091/ ) - grouping: Introduce TermGroupFacetCollectorManager for concurrent grouped faceting (https://github.com/apache/lucene/pull/16292) Thanks a lot! Luca --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
