Enforcing version and gradlew vs local shouldn't be difficult. As you said, Uwe, the version is gettable programmatically, and could be checked in the same check-environment script Dawid already mentioned. Whether or not the gradle wrapper is being used is a little tricker, but the code source for one of gradle's classes could be checked to be parented by gradle's home directory; I don't think modifications to gradlew are necessary, and should be avoided if at all possible.
On Sun, Sep 6, 2020 at 5:29 AM Uwe Schindler <u...@thetaphi.de> wrote: > Hi, > > I was thinking about a check, do build refuses to start when it figures > out that Gradle version is not exactly ours or it's stated not from gradlew > (I think we have something for checking if gradlew script has all > modifications). > > I think this should be doable? Getting version number of Gradle and equals > comparison is easy to do. > > Uwe > > Am September 6, 2020 11:08:55 AM UTC schrieb Tomoko Uchida < > tomoko.uchida.1...@gmail.com>: >> >> > remember the goal is to split Lucene and Solr repositories... >> >> As of 9.0.0 ? :) >> >> I found lucene/BUILD.md needs to be refined anyways (it contains >> information for Solr devs for some reason), so I opened a PR. >> https://github.com/apache/lucene-solr/pull/1835 >> Please review it, I'd merge it in the next few days if there is no >> disapproval. >> >> > As a novice gradle user these questions put me in the mind of a "new >> dev" coming to lucene, and I thought "Let's check the README!" ... where I >> see instructions to use './gradlew' mentioned (and pointers to './gradlew >> help') but nothing that really jumps out at me at screams "It's really >> important to use './gradlew' not 'gradle' (or 'gw') and here's why: ..." >> >> Also I elaborated the build tutorial in both of top-level README and >> lucene/BUILD.md for newdevs a little (at least we should note the JDK >> version in the top-level README?) I assume it'd be sufficient for new >> "developers" (My sense is somewhere in the middle of newbies and core >> developers.) >> I don't see the good reason that we officially mention any aliases or 3rd >> party tools for convenience, but feel free to edit it if it's worth. >> >> 2020年9月6日(日) 16:46 Dawid Weiss <dawid.we...@gmail.com>: >> >>> I'd rather move things out of the top-level and into solr/ lucene/ >>> folders - remember the goal is to split Lucene and Solr >>> repositories... >>> >>> Dawid >>> >>> On Sun, Sep 6, 2020 at 2:46 AM Tomoko Uchida >>> <tomoko.uchida.1...@gmail.com> wrote: >>> > >>> > For what it's worth, we already have lucene/BUILD.md in the >>> repository: >>> https://github.com/apache/lucene-solr/blob/master/lucene/BUILD.md >>> > Maybe we can move it to top level folder (and elaborate it if it's >>> needed) ? >>> > I'd prefer that build information/tips can be quickly accessed without >>> jumping to wiki... >>> > >>> > 2020年9月5日(土) 3:56 Dawid Weiss <dawid.we...@gmail.com>: >>> >> >>> >> >>> >>> >>> >>> That gets kind of circular and the two can certainly get out of >>> sync... >>> >> >>> >> >>> >> Right. I personally much prefer editing text files in the repository >>> than wiki pages (and I rarely look at our cwiki, sadly). >>> >> >>> >> Dawid >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >>> For additional commands, e-mail: dev-h...@lucene.apache.org >>> >>> > -- > Uwe Schindler > Achterdiek 19, 28357 Bremen > https://www.thetaphi.de >
