auto for .adoc files will guard us from a Windows user checking in an .adoc file with CRLF ending in the future, won’t it? But if you leave it as «don’t touch» such a mistake may happen, which was the root cause triggered .gitattributes in the first place? Or do you mean that it now creates issues for Windows users in some way?
Jan > 27. jan. 2020 kl. 12:49 skrev Dawid Weiss <dawid.we...@gmail.com>: > >> Since the issue ended up being a bad regex in the build task, do you >> still want me to exclude adoc files specifically from gitattributes >> Dawid? I'll make the change if there's some particular reason why >> adoc files should be exempted here. But at a glance it seems like >> gitattributes wasn't the core problem here. > > Please read what Uwe wrote; the regexp was incorrect (didn't work for > Windows) but those > files were LF only in the repository. So to me gitattributes is/was > the problem as it changes > repository content on checkout/ update for Windows users. This must > *not* happen. > The current "auto" setting should default to "don't touch". > > D. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
