[ 
https://issues.apache.org/jira/browse/SOLR-13680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16903900#comment-16903900
 ] 

Munendra S N commented on SOLR-13680:
-------------------------------------

[^SOLR-13680.patch] 
 Tests were failing due to change in {{ManagedSchema}} so, I have removed them. 
Stream closing is already handled 
[here|https://github.com/apache/lucene-solr/blob/2e5c554fea0aea1dfeecb227777f03f18fb78cd4/solr/core/src/java/org/apache/solr/schema/ManagedIndexSchema.java#L142].

If the stream is closed early, managed-schema won't be persisted locally which 
causes test failures

> Close Resources Properly
> ------------------------
>
>                 Key: SOLR-13680
>                 URL: https://issues.apache.org/jira/browse/SOLR-13680
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: 8.2
>            Reporter: Furkan KAMACI
>            Assignee: Munendra S N
>            Priority: Major
>             Fix For: 8.3
>
>         Attachments: SOLR-13680.patch, SOLR-13680.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Files, streams or connections which implements Closeable or AutoCloseable 
> interface should be closed after use.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to