[ 
https://issues.apache.org/jira/browse/LUCENE-8894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875428#comment-16875428
 ] 

Tomoko Uchida commented on LUCENE-8894:
---------------------------------------

I've opened a pull request for this issue.
 I think it's a trivial change - move the SPI name lookup logic to 
{{AbstractAnalysisFactory}} from {{AnalysisSPILoader}} and call it from 
{{TokenizerFactory}}, {{CharFilterFactory}}, and {{TokenFilterFactory}}. I will 
commit it to the ASF repo's master and branch_8x in a few days if there are no 
comments or objections.

> Add APIs to tokenizer/charfilter/tokenfilter factories to get their SPI names 
> from concrete classes
> ---------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-8894
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8894
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/analysis
>            Reporter: Tomoko Uchida
>            Assignee: Tomoko Uchida
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, reflection tricks are needed to obtain SPI name (this is now 
> stored in static NAME fields in each factory class) from a concrete factory 
> class. While it is easy to implement that logic, it would be much better to 
> provide unified APIs to get SPI name from a factory class. In other words, 
> the APIs would provide "inverse" operation of {{lookupClass(String)}} method.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to