[ 
https://issues.apache.org/jira/browse/LUCENE-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871620#comment-16871620
 ] 

Atri Sharma commented on LUCENE-8875:
-------------------------------------

I meant Elasticsearch aggregates (although I am not sure if  this new proposed 
collector has a direct improvement in that front,  on second thought).

The meat of the point here is that I believe it is the path of minimal invasion 
if we introduced a new collector which clearly calls out that it is meant for 
cases when N is very large (>10k?), and lists out the benefits and trade offs 
clearly.

Are there any catches that are applicable here?

> Should TopScoreDocCollector Always Populate Sentinel Values?
> ------------------------------------------------------------
>
>                 Key: LUCENE-8875
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8875
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Atri Sharma
>            Priority: Major
>
> TopScoreDocCollector always initializes HitQueue as the PQ implementation, 
> and instruct HitQueue to populate with sentinels. While this is a great 
> safety mechanism, for very large datasets where the query's selectivity is 
> high, the sentinel population can be redundant and can become a large enough 
> bottleneck in itself. Does it make sense to introduce a new parameter in 
> TopScoreDocCollector which uses a heuristic (say number of hits > 10k) and 
> does not populate sentinels?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to