gerlowskija commented on a change in pull request #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#discussion_r296338706
##########
File path:
solr/solrj/src/test/org/apache/solr/client/solrj/response/TestSpellCheckResponse.java
##########
@@ -27,21 +29,22 @@
import org.junit.BeforeClass;
import org.junit.Test;
-import java.util.List;
+import junit.framework.Assert;
/**
* Test for SpellCheckComponent's response in Solrj
*
*
* @since solr 1.3
*/
-public class TestSpellCheckResponse extends SolrJettyTestBase {
+public class TestSpellCheckResponse extends EmbeddedSolrServerTestBase {
Review comment:
[Q] Why are you changing the base class of this test here? I'm fine with
introducing a new base test-class in this PR, and maybe we want to eventually
change other classes to use this new base. But I'd rather that happen in a
separate PR.
(That way, if tests start failing it's clear what's at fault. With the
changes bundled together like this it's harder to tell whether the bugfixes
caused any hypothetical test failures, or the test-changes themselves are
unsound.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
