[ 
https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16868717#comment-16868717
 ] 

Atri Sharma commented on LUCENE-8857:
-------------------------------------

{quote}Any chance we can select the tie-breaker based on if one of the TopDocs 
has a shardIndex != -1 and assert that all of them have it or not? Another 
option would be to have only one comparator and first tie-break on shardIndex 
and then on doc since we don't set the shard index it should be fine since they 
are all -1?
{quote}
Would that not defeat the purpose of passing in the custom tie breaker? I 
thought the reason we added passing in the Comparator was to allow users to 
specify custom tie breaking algorithms, and define a custom one. Am I missing 
something?

 

 

> Refactor TopDocs#Merge To Take In Custom Tie Breakers
> -----------------------------------------------------
>
>                 Key: LUCENE-8857
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8857
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Atri Sharma
>            Priority: Major
>         Attachments: LUCENE-8857.patch, LUCENE-8857.patch, LUCENE-8857.patch, 
> LUCENE-8857.patch, LUCENE-8857.patch
>
>
> In LUCENE-8829, the idea of having lambdas passed in to the API to allow 
> finer control over the process was discussed.
> This JIRA tracks adding a parameter to the API which allows passing in 
> lambdas to define custom tie breakers, thus allowing users to do custom 
> algorithms when required.
> CC: [~jpountz]  [~simonw] 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to