jpountz commented on a change in pull request #730: LUCENE-8868: New storing
strategy for BKD tree leaves with low cardinality
URL: https://github.com/apache/lucene-solr/pull/730#discussion_r295190299
##########
File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDReader.java
##########
@@ -530,7 +602,7 @@ private void visitCompressedDocValues(int[]
commonPrefixLengths, byte[] scratchP
private int readCompressedDim(IndexInput in) throws IOException {
int compressedDim = in.readByte();
- if (compressedDim < -1 || compressedDim >= numDataDims) {
+ if (compressedDim < -2 || compressedDim >= numDataDims) {
Review comment:
maybe fail if compressedDim is -2 and version is not gte
VERSION_LOW_CARDINALITY_LEAVES?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
