[
https://issues.apache.org/jira/browse/LUCENE-8853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866720#comment-16866720
]
Adrien Grand commented on LUCENE-8853:
--------------------------------------
I had to change the random directory creation logic to only use a
FileSwitchDirectory when newDirectory is called as opposed to newFSDirectory
since the hard-linking tests rely on the fact that newFSDirectory creates a
FSDirectory.
{noformat}
11:52:25 [junit4] Suite:
org.apache.lucene.store.TestHardLinkCopyDirectoryWrapper
11:52:25 [junit4] IGNOR/A 0.03s J3 |
TestHardLinkCopyDirectoryWrapper.testFsyncDoesntCreateNewFiles
11:52:25 [junit4] > Assumption #1: test only works for FSDirectory
subclasses
11:52:25 [junit4] IGNOR/A 0.02s J3 |
TestHardLinkCopyDirectoryWrapper.testPendingDeletions
11:52:25 [junit4] > Assumption #1: we can only install VirusCheckingFS on
an FSDirectory
11:52:25 [junit4] 2> NOTE: reproduce with: ant test
-Dtestcase=TestHardLinkCopyDirectoryWrapper -Dtests.method=testCopyHardLinks
-Dtests.seed=F143ACB5B6E7F830 -Dtests.slow=true -Dtests.badapples=true
-Dtests.locale=chr-US -Dtests.timezone=America/Metlakatla -Dtests.asserts=true
-Dtests.file.encoding=ISO-8859-1
11:52:25 [junit4] FAILURE 0.04s J3 |
TestHardLinkCopyDirectoryWrapper.testCopyHardLinks <<<
11:52:25 [junit4] > Throwable #1: java.lang.AssertionError:
expected:<(dev=801,ino=4719568)> but was:<(dev=801,ino=4719567)>
11:52:25 [junit4] > at
__randomizedtesting.SeedInfo.seed([F143ACB5B6E7F830:1016E6C04A87B1E0]:0)
11:52:25 [junit4] > at
org.apache.lucene.store.TestHardLinkCopyDirectoryWrapper.testCopyHardLinks(TestHardLinkCopyDirectoryWrapper.java:83)
11:52:25 [junit4] > at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
11:52:25 [junit4] > at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
11:52:25 [junit4] > at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
11:52:25 [junit4] > at
java.base/java.lang.reflect.Method.invoke(Method.java:566)
11:52:25 [junit4] > at
java.base/java.lang.Thread.run(Thread.java:834)
11:52:25 [junit4] 2> NOTE: leaving temporary files on disk at:
/var/lib/jenkins/workspace/apache+lucene-solr+master/lucene/build/misc/test/J3/temp/lucene.store.TestHardLinkCopyDirectoryWrapper_F143ACB5B6E7F830-001
11:52:25 [junit4] 2> NOTE: test params are: codec=Lucene80,
sim=Asserting(org.apache.lucene.search.similarities.AssertingSimilarity@3be4c8d6),
locale=chr-US, timezone=America/Metlakatla
11:52:25 [junit4] 2> NOTE: Linux 3.16.0-9-amd64 amd64/Oracle Corporation
11.0.2 (64-bit)/cpus=16,threads=1,free=416622920,total=536870912
11:52:25 [junit4] 2> NOTE: All tests run in this JVM:
[TestDiversifiedTopDocsCollector, TestHardLinkCopyDirectoryWrapper]
11:52:25 [junit4] Completed [7/14 (1!)] on J3 in 1.62s, 43 tests, 1 failure,
2 skipped <<< FAILURES!
{noformat}
> FileSwitchDirectory is broken if temp outputs are used
> ------------------------------------------------------
>
> Key: LUCENE-8853
> URL: https://issues.apache.org/jira/browse/LUCENE-8853
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Simon Willnauer
> Priority: Major
> Fix For: master (9.0), 8.2
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> FileSwitchDirectory basically doesn't work if tmp output are used for files
> that are explicitly mapped with extensions. here is a failing test:
> {code}
> 16:49:40 [junit4] Suite:
> org.apache.lucene.search.suggest.analyzing.BlendedInfixSuggesterTest
> 16:49:40 [junit4] 2> NOTE: reproduce with: ant test
> -Dtestcase=BlendedInfixSuggesterTest
> -Dtests.method=testBlendedSort_fieldWeightZero_shouldRankSuggestionsByPositionMatch
> -Dtests.seed=16D8C93DC8FE5192 -Dtests.slow=true -Dtests.badapples=true
> -Dtests.locale=pt-LU -Dtests.timezone=US/Michigan -Dtests.asserts=true
> -Dtests.file.encoding=ISO-8859-1
> 16:49:40 [junit4] ERROR 0.05s J1 |
> BlendedInfixSuggesterTest.testBlendedSort_fieldWeightZero_shouldRankSuggestionsByPositionMatch
> <<<
> 16:49:40 [junit4] > Throwable #1:
> java.nio.file.AtomicMoveNotSupportedException: _0.fdx__0.tmp -> _0.fdx:
> source and dest are in different directories
> 16:49:40 [junit4] > at
> __randomizedtesting.SeedInfo.seed([16D8C93DC8FE5192:20E180A9490374CE]:0)
> 16:49:40 [junit4] > at
> org.apache.lucene.store.FileSwitchDirectory.rename(FileSwitchDirectory.java:201)
> 16:49:40 [junit4] > at
> org.apache.lucene.store.MockDirectoryWrapper.rename(MockDirectoryWrapper.java:231)
> 16:49:40 [junit4] > at
> org.apache.lucene.store.LockValidatingDirectoryWrapper.rename(LockValidatingDirectoryWrapper.java:56)
> 16:49:40 [junit4] > at
> org.apache.lucene.store.TrackingDirectoryWrapper.rename(TrackingDirectoryWrapper.java:64)
> 16:49:40 [junit4] > at
> org.apache.lucene.store.FilterDirectory.rename(FilterDirectory.java:89)
> 16:49:40 [junit4] > at
> org.apache.lucene.index.SortingStoredFieldsConsumer.flush(SortingStoredFieldsConsumer.java:56)
> 16:49:40 [junit4] > at
> org.apache.lucene.index.DefaultIndexingChain.flush(DefaultIndexingChain.java:152)
> 16:49:40 [junit4] > at
> org.apache.lucene.index.DocumentsWriterPerThread.flush(DocumentsWriterPerThread.java:468)
> 16:49:40 [junit4] > at
> org.apache.lucene.index.DocumentsWriter.doFlush(DocumentsWriter.java:555)
> 16:49:40 [junit4] > at
> org.apache.lucene.index.DocumentsWriter.flushAllThreads(DocumentsWriter.java:722)
> 16:49:40 [junit4] > at
> org.apache.lucene.index.IndexWriter.prepareCommitInternal(IndexWriter.java:3199)
> 16:49:40 [junit4] > at
> org.apache.lucene.index.IndexWriter.commitInternal(IndexWriter.java:3444)
> 16:49:40 [junit4] > at
> org.apache.lucene.index.IndexWriter.commit(IndexWriter.java:3409)
> 16:49:40 [junit4] > at
> org.apache.lucene.search.suggest.analyzing.AnalyzingInfixSuggester.commit(AnalyzingInfixSuggester.java:345)
> 16:49:40 [junit4] > at
> org.apache.lucene.search.suggest.analyzing.AnalyzingInfixSuggester.build(AnalyzingInfixSuggester.java:315)
> 16:49:40 [junit4] > at
> org.apache.lucene.search.suggest.analyzing.BlendedInfixSuggesterTest.getBlendedInfixSuggester(BlendedInfixSuggesterTest.java:125)
> 16:49:40 [junit4] > at
> org.apache.lucene.search.suggest.analyzing.BlendedInfixSuggesterTest.testBlendedSort_fieldWeightZero_shouldRankSuggestionsByPositionMatch(BlendedInfixSuggesterTest.java:79)
> 16:49:40 [junit4] > at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 16:49:40 [junit4] > at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 16:49:40 [junit4] > at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 16:49:40 [junit4] > at
> java.base/java.lang.reflect.Method.invoke(Method.java:566)
> 16:49:40 [junit4] > at
> java.base/java.lang.Thread.run(Thread.java:834)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
