msokolov commented on a change in pull request #722: LUCENE-8863: handle some
edge cases in Kuromoji DictionaryBuilder, en…
URL: https://github.com/apache/lucene-solr/pull/722#discussion_r294472350
##########
File path:
lucene/analysis/kuromoji/src/tools/java/org/apache/lucene/analysis/ja/util/BinaryDictionaryWriter.java
##########
@@ -126,7 +132,9 @@ public int put(String[] entry) {
buffer.putShort(wordCost);
if ((flags & BinaryDictionary.HAS_BASEFORM) != 0) {
- assert baseForm.length() < 16;
+ if (baseForm.length() >= 16) {
Review comment:
Could you elaborate? I do see the exception message is wrong (should say
>=), but I think the assertion is correct" `len < 16` iff `!(len >= 16)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
