jpountz commented on a change in pull request #633: LUCENE-8753 UniformSplit
PostingsFormat
URL: https://github.com/apache/lucene-solr/pull/633#discussion_r294159108
##########
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80Codec.java
##########
@@ -91,7 +91,11 @@ public Lucene80Codec() {
* flushed/merged segments.
*/
public Lucene80Codec(Mode mode) {
- super("Lucene80");
+ this("Lucene80", mode);
+ }
+
+ protected Lucene80Codec(String name, Mode mode) {
+ super(name);
Review comment:
Has this binary search within blocks proved useful? In general I don't have
objections to adding new file formats, but I'm a bit worried when they use
implementation details of existing file formats instead of using APIs, as this
might make these other formats harder to evolve.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
