vthacker commented on a change in pull request #707: Use append() when
StringBuilder is being used, instead of regular concat.
URL: https://github.com/apache/lucene-solr/pull/707#discussion_r291900796
##########
File path:
solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestVariableResolverEndToEnd.java
##########
@@ -77,34 +77,11 @@ protected String generateConfig() {
"from DUAL \" >\n");
sb.append(" <field column=\"SELECT_KEYWORD\" name=\"select_keyword_s\" />
\n");
sb.append(" <entity name=\"SECOND\" processor=\"SqlEntityProcessor\"
dataSource=\"hsqldb\" transformer=\"TemplateTransformer\" ");
- sb.append(" query=\"" +
- "${dataimporter.functions.encodeUrl(FIRST.SELECT_KEYWORD)} " +
- " 1 as SORT, " +
- " {ts '2017-02-18 12:34:56'} as SECOND_TS, " +
- " '${dataimporter.functions.formatDate(FIRST.FIRST_TS, 'yyyy'" +
thirdLocaleParam + ")}' as SECOND1_S, " +
- " 'PORK' AS MEAT, " +
- " 'GRILL' AS METHOD, " +
- " 'ROUND' AS CUTS, " +
- " 'BEEF_CUTS' AS WHATKIND " +
- "from DUAL " +
- "WHERE 1=${FIRST.ID} " +
- "UNION " +
- "${dataimporter.functions.encodeUrl(FIRST.SELECT_KEYWORD)} " +
- " 2 as SORT, " +
- " {ts '2017-02-18 12:34:56'} as SECOND_TS, " +
- " '${dataimporter.functions.formatDate(FIRST.FIRST_TS, 'yyyy'" +
thirdLocaleParam + ")}' as SECOND1_S, " +
- " 'FISH' AS MEAT, " +
- " 'FRY' AS METHOD, " +
- " 'SIRLOIN' AS CUTS, " +
- " 'BEEF_CUTS' AS WHATKIND " +
- "from DUAL " +
- "WHERE 1=${FIRST.ID} " +
- "ORDER BY SORT \"" +
- ">\n");
Review comment:
I think we should leave out test files? The above is just so much more
readable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
