Koen De Groote created SOLR-13533:
-------------------------------------

             Summary: Code Cleanup - Performance
                 Key: SOLR-13533
                 URL: https://issues.apache.org/jira/browse/SOLR-13533
             Project: Solr
          Issue Type: Improvement
      Security Level: Public (Default Security Level. Issues are Public)
            Reporter: Koen De Groote


Code cleanup as suggested by static analysis tools. Will be done in my spare 
time.

If someone reviews this, please also do not take up actual time from your work 
to do that.

 

These are simple, trivial things, that were probably overlooked or not even 
considered(which isn't an accusation or something negative). But also stuff 
that the Java compiler/JIT won't optimize on its own.

 

That's what static analysis tool are good for: picking stuff like that up.

 

I'm talking about Intellij's static code analysis. Facebook's "Infer" for Java. 
Google's "errorprone", etc...

These are the kinds of things that, frankly, for the people actually working on 
real features, are very time consuming and have a very low chance of actually 
turning up a real performance issue.

So I'm opting to have a look at the results of these tools and implementing the 
sensible stuff and if something bigger pops up I'll make a separate ticket for 
those things individually.

 

Creating this ticket so I can name a branch after it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to