[
https://issues.apache.org/jira/browse/SOLR-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843232#comment-16843232
]
Erick Erickson commented on SOLR-12697:
---------------------------------------
OK. I confess I didn't dive into the entire process, on a quick review it
caught my eye 'cause it looked a bit like fetching the stored doc in a
collector, which is an anti-pattern.
Also making it not as bad is that aside from the documentCache, the page
containing the compressed data will probably be in memory even if it's accessed
multiple times. The decompression set would cause extra work in that case.
I'm not quite sure how the documentCache would be populated, and don't have
time right now to check whether it's part of this workflow or need an explicit
call. Just a cautionary note for you to check that this code would insert the
doc in the cache if you're expecting it to be used.
> pure DocValues support for FieldValueFeature
> --------------------------------------------
>
> Key: SOLR-12697
> URL: https://issues.apache.org/jira/browse/SOLR-12697
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - LTR
> Reporter: Stanislav Livotov
> Priority: Major
> Attachments: SOLR-12697.patch, SOLR-12697.patch, SOLR-12697.patch,
> SOLR-12697.patch, SOLR-12697.patch
>
>
> [~slivotov] wrote in SOLR-12688:
> bq. ... FieldValueFeature doesn't support pure DocValues fields (Stored
> false). Please also note that for fields which are both stored and DocValues
> it is working not optimal because it is extracting just one field from the
> stored document. DocValues are obviously faster for such usecases. ...
> (Please see SOLR-12688 description for overall context and analysis results.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
