[ 
https://issues.apache.org/jira/browse/SOLR-13155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16766434#comment-16766434
 ] 

Jason Gerlowski commented on SOLR-13155:
----------------------------------------

Hey [~ab], took a look at your latest patch this morning while preparing to 
write a Windows equivalent of the {{bin/solr}} bits you just added.  One 
question:

You add a {{print_usage}} section for the new autoscaling command...
{code}
+  elif [ "$CMD" == "autoscaling" ]; then
+    echo ""
+    echo "Usage: solr autoscaling [-z zkHost] [-a <autoscaling.json.file>] 
[-s] [-d] [-n] [-r]"
+    echo ""
+    echo "  Calculate autoscaling policy suggestions and diagnostic 
information, using either the deployed"
+    echo "  autoscaling configuration or the one supplied on the command line. 
This calculation takes place"
+    echo "  on the client-side without affecting the running cluster except 
for fetching the node and replica"
+    echo "  metrics from the cluster. For detailed usage instructions, do:"
+    echo ""
+    echo "    bin/solr autoscaling -help"
+    echo ""
{code}

But I can't figure out what command would actually trigger this help text.  The 
"autoscaling" command defers parsing its args until Java-land, so any 
{{-h}}/{{--help}}/etc. argument will trigger the commons-cli generated help 
text instead:

{code}
➜  solr git:(master) ✗ bin/solr autoscaling -h
INFO  - 2019-02-12 15:33:01.434; 
org.apache.solr.util.configuration.SSLCredentialProviderFactory; Processing SSL 
Credential Provider chain: env;sysprop
Failed to parse command-line arguments due to: Unrecognized option: -h
usage: org.apache.solr.util.SolrCLI
 -a,--config <CONFIG>   Autoscaling config file, defaults to the one
                        deployed in the cluster.
 -all                   Turn on all options to get all available
                        information.
 -c,--clusterState      Show ClusterState (collections layout)
 -d,--diagnostics       Show calculated diagnostics
 -help                  Print this message
 -n,--sortedNodes       Show sorted nodes with diagnostics
 -r,--redact            Redact node and collection names (original names
                        will be consistently randomized)
 -s,--suggestions       Show calculated suggestions
 -stats                 Show summarized collection & node statistics.
 -verbose               Generate verbose log messages
 -zkHost <HOST>         Address of the Zookeeper ensemble; defaults to:
                        localhost:9983
{code}

Am I missing some command that manages to trigger that help text, or is it 
dead-code that we can remove or change?  (I'm only asking so I know whether to 
include similar help text in the solr.cmd version.  If the {{bin/solr}} help 
text is dead code, I'm happy to remove it for you when I commit plumbing on the 
Windows side tomorrow.)


> CLI tool for testing autoscaling suggestions against a live cluster
> -------------------------------------------------------------------
>
>                 Key: SOLR-13155
>                 URL: https://issues.apache.org/jira/browse/SOLR-13155
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: AutoScaling
>            Reporter: Andrzej Bialecki 
>            Assignee: Andrzej Bialecki 
>            Priority: Major
>             Fix For: 8.0, master (9.0)
>
>         Attachments: SOLR-13155.patch, SOLR-13155.patch, SOLR-13155.patch
>
>
> Solr already provides /autoscaling/diagnostics and /autoscaling/suggestions 
> endpoints. In some situations it would be very helpful to be able to run 
> "what if" scenarios using data about nodes and replicas taken from a 
> production cluster but with a different autoscaling policy than the one that 
> is deployed, without also worrying that the calculations would negatively 
> impact a production cluster's Overseer leader.
> All necessary classes (including the Policy engine) are self-contained in the 
> SolrJ component, so it's just a matter of packaging and writing a CLI tool + 
> a wrapper script.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to