uschindler commented on issue #553: SOLR-9515: Update to Hadoop 3 URL: https://github.com/apache/lucene-solr/pull/553#issuecomment-458975651 @risdenk Thanks. That's exactly what I expected. Thanks for explanation. I am fine with that solution (because it's test only, so we don't deliver that to the end user for use in production). To me it's only important to clarify: If we want to go that route, it's important to have our own test classes BEFORE the hadoop imports on classpath. We have to make sure that this also applies for the Eclipse/NetBeans/... Development integrations! So I am fine with the approach, but we need to make the build system be informed about that. We also should not disable our source code and license checks on the forked Hadoop classes! If there are violations, we should maybe fix them at least in the code we imported.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
