[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745943#comment-16745943
]
Mikhail Khludnev commented on LUCENE-8640:
------------------------------------------
Thanks for the contribution!. For matter of taste, this code is a little bit
_explicit_, I expected it to validate as it parses, but it's really hard to
judge about performance without benchmark.
[~dsmiley], can we afford such kind of validation? I'll take care about commit,
if you don't mind.
Aslo, [~lsharma3], please beware about patch naming habit
https://wiki.apache.org/solr/HowToContribute#Creating_the_patch_file.
> validate delimiters when parsing date ranges
> --------------------------------------------
>
> Key: LUCENE-8640
> URL: https://issues.apache.org/jira/browse/LUCENE-8640
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial
> Reporter: Mikhail Khludnev
> Priority: Major
> Attachments: mypatch.patch
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> {{DateRangePrefixTree.parseCalendar()}} should validate delimiters to rejects
> dates like {{2000-11T13}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
