[ 
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734046#comment-16734046
 ] 

Murali Krishna P commented on LUCENE-8601:
------------------------------------------

Thanks [~mikemccand]. Uploaded a separate patch for 7x branch 
[^7x_LUCENE-8601.06.patch]

Regarding modifying the attribute, will open another issue as you suggested. We 
need to discuss how we should treat the scenarios if some attributes don't 
present in the subsequent update. Most of the use cases will have the 
attributes defined at the beginning itself and unlikely to change.

> Adding attributes to IndexFieldType
> -----------------------------------
>
>                 Key: LUCENE-8601
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8601
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/index
>    Affects Versions: 7.5
>            Reporter: Murali Krishna P
>            Priority: Major
>         Attachments: 7x_LUCENE-8601.06.patch, LUCENE-8601.01.patch, 
> LUCENE-8601.02.patch, LUCENE-8601.03.patch, LUCENE-8601.04.patch, 
> LUCENE-8601.05.patch, LUCENE-8601.06.patch, LUCENE-8601.patch
>
>
> Today, we can write a custom Field using custom IndexFieldType, but when the 
> DefaultIndexingChain converts [IndexFieldType to 
> FieldInfo|https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java#L662],
>  only few key informations such as indexing options and doc value type are 
> retained. The [Codec gets the 
> FieldInfo|https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/codecs/DocValuesConsumer.java#L90],
>  but not the type details.
>   
>  FieldInfo has support for ['attributes'| 
> https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/index/FieldInfo.java#L47]
>  and it would be great if we can add 'attributes' to IndexFieldType also and 
> copy it to FieldInfo's 'attribute'.
>   
>  This would allow someone to write a custom codec (extending docvalueformat 
> for example) for only the 'special field' that he wants and delegate the rest 
> of the fields to the default codec.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to