[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728862#comment-16728862
]
Murali Krishna P commented on LUCENE-8601:
------------------------------------------
You are right, [~mikemccand]. The FieldInfo has an existing bug where the
attributes are lost during merging. However, fixing it seems tricky as the
existing classes relies on that bug (or is it by design?). PerField formats
uses the attributes for storing format and suffix and they expect it to be null
and generate new values during merge. Eventhough the attributes are mainly
useful during index time, it might be good to persist it even after merge. I
will make an attempt to change these PerField formats to overwrite the
attributes, but these has explicit asserts right now to ensure the attributes
are null and I am concerned I might be breaking something. Please let me know
if you see any concerns with that approach.
> Adding attributes to IndexFieldType
> -----------------------------------
>
> Key: LUCENE-8601
> URL: https://issues.apache.org/jira/browse/LUCENE-8601
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
> Affects Versions: 7.5
> Reporter: Murali Krishna P
> Priority: Major
> Attachments: LUCENE-8601.01.patch, LUCENE-8601.02.patch,
> LUCENE-8601.03.patch, LUCENE-8601.04.patch, LUCENE-8601.patch
>
>
> Today, we can write a custom Field using custom IndexFieldType, but when the
> DefaultIndexingChain converts [IndexFieldType to
> FieldInfo|https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java#L662],
> only few key informations such as indexing options and doc value type are
> retained. The [Codec gets the
> FieldInfo|https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/codecs/DocValuesConsumer.java#L90],
> but not the type details.
>
> FieldInfo has support for ['attributes'|
> https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/index/FieldInfo.java#L47]
> and it would be great if we can add 'attributes' to IndexFieldType also and
> copy it to FieldInfo's 'attribute'.
>
> This would allow someone to write a custom codec (extending docvalueformat
> for example) for only the 'special field' that he wants and delegate the rest
> of the fields to the default codec.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
