[
https://issues.apache.org/jira/browse/SOLR-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714118#comment-16714118
]
Stanislav Livotov commented on SOLR-13049:
------------------------------------------
Agree with everything, except I'm not sure whether a default value is
applicable for all type of features. For example FieldLength and OriginalScore.
But anyway I agree with the attached patch.
Yep, I don't see any issues with combining this Jira patches, if this patch
will be applied before then we will have to cut changes from Feature and
FieldValueFeature#paramsToMap() of SOLR-12697 patch.
> make contrib/ltr Feature.defaultValue configurable
> --------------------------------------------------
>
> Key: SOLR-13049
> URL: https://issues.apache.org/jira/browse/SOLR-13049
> Project: Solr
> Issue Type: New Feature
> Components: contrib - LTR
> Reporter: Stanislav Livotov
> Priority: Major
> Attachments: SOLR-13049.patch
>
>
> [~slivotov] wrote in SOLR-12697:
> {quote}
> I had also done a couple of additional code changes:
> 1. fixed small issue with defaultValue(previously it was impossible to set it
> from feature.json, and the tests were written where Feature was created
> manually, and not by parsing json). Tests are added which are validating
> defaultValue from schema field configuration and from a feature default value.
> {quote}
> (Please see
> https://issues.apache.org/jira/browse/SOLR-12697?focusedCommentId=16708618&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16708618
> for more context.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
