Github user jpountz commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/513#discussion_r239114521
  
    --- Diff: lucene/core/src/java/org/apache/lucene/index/BufferedUpdates.java 
---
    @@ -288,15 +184,24 @@ void clear() {
         deleteTerms.clear();
         deleteQueries.clear();
         deleteDocIDs.clear();
    -    numericUpdates.clear();
    -    binaryUpdates.clear();
         numTermDeletes.set(0);
    -    numNumericUpdates.set(0);
    -    numBinaryUpdates.set(0);
    -    bytesUsed.set(0);
    +    numFieldUpdates.set(0);
    +    fieldUpdates.clear();
    +    bytesUsed.addAndGet(-bytesUsed.get());
    +    fieldUpdatesBytesUsed.addAndGet(-fieldUpdatesBytesUsed.get());
       }
       
       boolean any() {
    -    return deleteTerms.size() > 0 || deleteDocIDs.size() > 0 || 
deleteQueries.size() > 0 || numericUpdates.size() > 0 || binaryUpdates.size() > 
0;
    +    return deleteTerms.size() > 0 || deleteDocIDs.size() > 0 || 
deleteQueries.size() > 0 || numFieldUpdates.get() > 0;
    +  }
    +
    +  @Override
    +  public long ramBytesUsed() {
    +    return bytesUsed.get() + fieldUpdatesBytesUsed.get();
    +  }
    +
    +  public void clearDeletedDocIds() {
    --- End diff --
    
    no need for the public modifier?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to