[
https://issues.apache.org/jira/browse/SOLR-13027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708690#comment-16708690
]
Jason Gerlowski edited comment on SOLR-13027 at 12/4/18 1:20 PM:
-----------------------------------------------------------------
Looks like you added an empty/useless if-statement
[here|https://github.com/apache/lucene-solr/blob/33c40a8da40677f43ea377ca0cb2a1def8649c52/solr/solrj/src/java/org/apache/solr/client/solrj/impl/SolrClientNodeStateProvider.java#L310].
Assuming that was an accident?
Also, I noticed elsewhere that the cleanup command in LeaderTragicEventTest
[here|https://github.com/apache/lucene-solr/blob/75b183196798232aa6f2dcaaaab117f309119053/solr/core/src/test/org/apache/solr/cloud/LeaderTragicEventTest.java#L193]
often/always ( ? ) fails due to a race condition where the overseer doesn't
get rid of connections orphaned/closed by the Jetty restart. We ask the
overseer to delete a collection for us and it fails because it tries to use
these old connections. (You helped me out on this yesterday offline actually,
though I don't think I mentioned this test by name at the time.). Anyway, this
cleanup failure doesn't typically cause test failures due to a different bug
altogether (SOLR-6595), but if you're beasting you might see the incomplete
cleanup cause issues so I wanted to mention it.
was (Author: gerlowskija):
Looks like you added an empty/useless if-statement
[here|https://github.com/apache/lucene-solr/blob/33c40a8da40677f43ea377ca0cb2a1def8649c52/solr/solrj/src/java/org/apache/solr/client/solrj/impl/SolrClientNodeStateProvider.java#L310].
Assuming that was an accident?
Also, I noticed elsewhere that the cleanup command in LeaderTragicEventTest
[here|https://github.com/apache/lucene-solr/blob/75b183196798232aa6f2dcaaaab117f309119053/solr/core/src/test/org/apache/solr/cloud/LeaderTragicEventTest.java#L193]
often/always(?) fails due to a race condition where the overseer doesn't get
rid of connections orphaned/closed by the Jetty restart. We ask the overseer
to delete a collection for us and it fails because it tries to use these old
connections. (You helped me out on this yesterday offline actually, though I
don't think I mentioned this test by name at the time.). Anyway, this cleanup
failure doesn't typically cause test failures due to a different bug altogether
(SOLR-6595), but if you're beasting you might see the incomplete cleanup cause
issues so I wanted to mention it.
> Harden LeaderTragicEventTest.
> -----------------------------
>
> Key: SOLR-13027
> URL: https://issues.apache.org/jira/browse/SOLR-13027
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Tests
> Reporter: Mark Miller
> Assignee: Mark Miller
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
