[ 
https://issues.apache.org/jira/browse/LUCENE-8575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704437#comment-16704437
 ] 

ASF subversion and git services commented on LUCENE-8575:
---------------------------------------------------------

Commit c2ab04775dd2b683f96e65c78a7a3696396d2263 in lucene-solr's branch 
refs/heads/master from [~danmuzi]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c2ab047 ]

LUCENE-8575: Improve toString() in SegmentInfo

Signed-off-by: Namgyu Kim <[email protected]>
Signed-off-by: Adrien Grand <[email protected]>


> Improve toString() in SegmentInfo
> ---------------------------------
>
>                 Key: LUCENE-8575
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8575
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/index
>            Reporter: Namgyu Kim
>            Priority: Major
>         Attachments: LUCENE-8575.patch, LUCENE-8575.patch
>
>
> I saw the following code in SegmentInfo class.
> {code:java}
> // TODO: we could append toString of attributes() here?
> {code}
> Of course, we can.
>  
> So I wrote a code for that part.
> {code:java}
> public String toString(int delCount) {
>   StringBuilder s = new StringBuilder();
>   s.append(name).append('(').append(version == null ? "?" : 
> version).append(')').append(':');
>   char cfs = getUseCompoundFile() ? 'c' : 'C';
>   s.append(cfs);
>   s.append(maxDoc);
>   if (delCount != 0) {
>     s.append('/').append(delCount);
>   }
>   if (indexSort != null) {
>     s.append(":[indexSort=");
>     s.append(indexSort);
>     s.append(']');
>   }
>   // New Code
>   if (!diagnostics.isEmpty()) {
>     s.append(":[diagnostics=");
>     for (Map.Entry<String, String> entry : diagnostics.entrySet())
>       
> s.append("<").append(entry.getKey()).append(",").append(entry.getValue()).append(">,");
>     s.setLength(s.length() - 1);
>     s.append(']');
>   }
>   // New Code
>   if (!attributes.isEmpty()) {
>     s.append(":[attributes=");
>     for (Map.Entry<String, String> entry : attributes.entrySet())
>       
> s.append("<").append(entry.getKey()).append(",").append(entry.getValue()).append(">,");
>     s.setLength(s.length() - 1);
>     s.append(']');
>   }
>   return s.toString();
> }
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to