[
https://issues.apache.org/jira/browse/LUCENE-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697223#comment-16697223
]
Adrien Grand commented on LUCENE-8562:
--------------------------------------
Thanks Ignacio. I would expect this new code path to be quite rare so I'm not
sure it is worth optimizing to the point of reusing a slice that isn't shared.
Let's maybe remove the following lines?
{code}
+ //find a slice that is not shared between nodes of the tree.
+ for (int i = 0; i < numIndexDims; i++) {
+ if (slices[i].start == 0 && slices[i].count ==
((HeapPointWriter) slices[i].writer).maxSize) {
+ dataDimPathSlice = slices[i];
+ break;
+ }
+ }
{code}
> Speed up merging segments of points with data dimensions
> --------------------------------------------------------
>
> Key: LUCENE-8562
> URL: https://issues.apache.org/jira/browse/LUCENE-8562
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
> Affects Versions: master (8.0), 7.7
> Reporter: Ignacio Vera
> Priority: Major
> Attachments: LUCENE-8562.patch, LUCENE-8562.patch, LUCENE-8562.patch,
> LUCENE-8562.patch, LUCENE-8562.patch
>
>
> Currently when merging segments of points with data dimensions, all
> dimensions are sorted and carried over down the tree even though only
> indexing dimensions are needed to build the BKD tree. This is needed so leaf
> node data can be compressed by common prefix.
> But when using _MutablePointValues_, this ordering is done at the leaf level
> so we can se a similar approach from data dimensions and delay the sorting at
> leaf level. This seems to speed up indexing time as well as reduce the
> storage needed for building the index.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
