[
https://issues.apache.org/jira/browse/SOLR-12991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688868#comment-16688868
]
Mark Miller commented on SOLR-12991:
------------------------------------
Yeah, would be nice to log the root error at the least.
I don't know that we do want to log it as error or warn which indicates either
something has gone wrong or there is something you might want to worry about -
it's actually rather normal for recovery to fail talking to someone during
cluster transitions - kind of seems more informational to say io communication
went wrong and we are retrying or whatever.
> RecoveryStrategy should mention the root cause
> ----------------------------------------------
>
> Key: SOLR-12991
> URL: https://issues.apache.org/jira/browse/SOLR-12991
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Affects Versions: 7.5
> Reporter: Varun Thacker
> Priority: Major
>
> Here is a log line which could be more informative to help debug the root
> cause.
> {code:java}
> date time INFO (recoveryExecutor-4-thread-6-processing-n:host:port_solr
> x:coll_shard1_replica_n203 c:coll s:shard1 r:core_node204) [c:coll s:shard1
> r:core_node204 x:coll_shard1_replica_n203] o.a.s.c.RecoveryStrategy Failed to
> connect leader https://host:8985/solr on recovery, try again{code}
>
> In these code paths we should make sure the root cause is mentioned. Also
> these should be WARNs or ERRORs
> {code:java}
> catch (IOException e) {
> log.info("Failed to connect leader {} on recovery, try again",
> leaderReplica.getBaseUrl());
> Thread.sleep(500);
> } catch (Exception e) {
> if (e.getCause() instanceof IOException) {
> log.info("Failed to connect leader {} on recovery, try again",
> leaderReplica.getBaseUrl());
> Thread.sleep(500);
> } else {
> return leaderReplica;
> }
> }{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
