Github user cbismuth commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/497#discussion_r233517397
  
    --- Diff: 
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ---
    @@ -100,13 +109,156 @@ public CacheHelper getCoreCacheHelper() {
     
       }
     
    +  /**
    +   * Wrapper class for another PointValues implementation that is used by 
ExitableFields.
    +   */
    +  public static class ExitablePointValues extends PointValues {
    +
    +    private final PointValues in;
    +    private final QueryTimeout queryTimeout;
    +
    +    public ExitablePointValues(PointValues in, QueryTimeout queryTimeout) {
    --- End diff --
    
    Issue found: I forgot to add a `set -e` statement in my tiny bash script 
below to stop on first failure.
    
    Let me run another `precommit` Ant task and push.
    
    ```bash
    #!/usr/bin/env bash
    
    set -e
    
    cd ${HOME}/git/lucene-solr
    find . -name "*.lck" -delete
    ant clean compile precommit
    ant -f lucene/build.xml test
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to