Github user cbismuth commented on the issue:

    https://github.com/apache/lucene-solr/pull/495
  
    Lucene tests are all green on my side, I'll launch Solr ones later this day.
    
    I'm not at ease with these two changes 
[here](https://github.com/apache/lucene-solr/pull/495/files#diff-4c736ed817068ac157cd867fa1dc6418R769)
 and 
[there](https://github.com/apache/lucene-solr/pull/495/files#diff-4c736ed817068ac157cd867fa1dc6418R847).
 I'm not sure I can _easily_ retrieve the score mode from the 
`CachingWrapperWeight` class, therefore I passed `ScoreMode.TOP_SCORE` to not 
prevent from setting min competitive score.
    
    What do you think about it?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to