[ 
https://issues.apache.org/jira/browse/SOLR-12698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675742#comment-16675742
 ] 

Christine Poerschke commented on SOLR-12698:
--------------------------------------------

bq. ... the intention to introduce both q(which is supposed to be a function 
query) and fq parameter for the same SolrFeature at all(Is there a case when 
they will be used together ? ), ...

A fair question. We could probably document this better, somehow. The 
[SolrFeature 
javadocs|http://lucene.apache.org/solr/7_5_0/solr-ltr/org/apache/solr/ltr/feature/SolrFeature.html]
 currently only say "... The value of the feature will be the score of the 
given query for the current document. ..." and although the example 
configurations have both {{fq}} and {{q}} (individually) it's unstated when one 
might wish to use which or both. In essence (as far as a i recall) like with 
the [fq query 
parameter|https://lucene.apache.org/solr/guide/7_5/common-query-parameters.html#fq-filter-query-parameter]
 itself the {{fq}} in {{SolrFeature}} can be used to restrict which documents 
score non-zero but without influencing the document score itself.

> SolrFeature: no-fq optimisation
> -------------------------------
>
>                 Key: SOLR-12698
>                 URL: https://issues.apache.org/jira/browse/SOLR-12698
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: contrib - LTR
>            Reporter: Stanislav Livotov
>            Priority: Major
>         Attachments: SOLR-12698.patch
>
>
> [~slivotov] wrote in SOLR-12688:
> bq. ... SolrFeature was not optimally implemented for the case when no fq 
> parameter was passed. I'm not absolutely sure what was the intention to 
> introduce both q(which is supposed to be a function query) and fq parameter 
> for the same SolrFeature at all(Is there a case when they will be used 
> together ? ), so I decided not to change behavior but just optimize described 
> case ...
> (Please see SOLR-12688 description for overall context and analysis results.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to