Github user dsmiley commented on the pull request:
https://github.com/apache/lucene-solr/commit/43d7f5d104802bc3281d5995c6c2d71bebf1f369#commitcomment-31121980
I understand it's a design decision. I'm not certain about the correctness
of the logic; I've been leaving that to you here; DUP is a mess to untangle. I
think your method name is still inappropriate -- for example "if
(sdoc.hasChildDocuments()) return true" thus even it's not an update, we still
can return true. So instead lets name the method based on why the caller cares
-- it wants to know wether to get the version or not. Put on DUP. The method
is not clean enough or general enough to go on the Cmd.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
