[
https://issues.apache.org/jira/browse/SOLR-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651669#comment-16651669
]
Christine Poerschke commented on SOLR-5004:
-------------------------------------------
[~anshumg], [~varunthacker] and I were chatting yesterday re: the name for the
parameter. And so today I got curious about the code changes themselves.
Attached revised SOLR-5004.03.patch with proposed changes as follows:
* rename MAX_SPLITS constant to MAX_NUM_SUB_SHARDS
* introduce MIN_NUM_SUB_SHARDS, DEFAULT_NUM_SUB_SHARDS and
CommonAdminParams.NUM_SUB_SHARDS constants
* looked for mentions of "two" or "2" in SplitShardCmd.java
** found and adjusted in two places
** identified third place [TODO: change this to handle sharding a slice into >
2
sub-shards.|https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.5.0/solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java#L353]
but as yet unclear on whether or not that just needs removal or an actual
change
* replaced println in test
* added minimal Solr Ref Guide change
> Allow a shard to be split into 'n' sub-shards
> ---------------------------------------------
>
> Key: SOLR-5004
> URL: https://issues.apache.org/jira/browse/SOLR-5004
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
> Affects Versions: 4.3, 4.3.1
> Reporter: Anshum Gupta
> Assignee: Anshum Gupta
> Priority: Major
> Attachments: SOLR-5004.01.patch, SOLR-5004.02.patch,
> SOLR-5004.03.patch, SOLR-5004.patch, SOLR-5004.patch
>
>
> As of now, a SPLITSHARD call is hardcoded to create 2 sub-shards from the
> parent one. Accept a parameter to split into n sub-shards.
> Default it to 2 and perhaps also have an upper bound to it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
