[ 
https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611153#comment-16611153
 ] 

Joel Bernstein edited comment on SOLR-11836 at 9/11/18 7:49 PM:
----------------------------------------------------------------

I was just looking this over and testing some things out locally.

I tested just sending -1 to the JSON facet API and it didn't return results. 
It's also not a documented thing to do.

I see that the patch sets the limit to Integer.MAX_VALUE. It would be good to 
understand how this effects the internal data structures used by the JSON facet 
API. For example it's possible that the JSON API is pre-allocating one or more 
arrays of that size. This would not be an unusual thing todo inside Solr. If 
that's the case then setting limit to Integer.MAX_VALUE would be something that 
we want to avoid.


was (Author: joel.bernstein):
I was just looking this over and testing some things out locally.

I tested just sending -1 to the JSON -f-acet API and it didn't return results. 
It's also not a documented thing to do.

I see that the patch sets the limit to Integer.MAX_VALUE. It would be good to 
understand how this effects the internal data structures used by the JSON facet 
API. For example it's possible that the JSON API is pre-allocating one or more 
arrays of that size. This would not be an unusual thing todo inside Solr. If 
that's the case then setting limit to Integer.MAX_VALUE would be something that 
we want to avoid.

> Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
> ----------------------------------------------------------------------------
>
>                 Key: SOLR-11836
>                 URL: https://issues.apache.org/jira/browse/SOLR-11836
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: streaming expressions
>            Reporter: Alfonso Muñoz-Pomer Fuentes
>            Priority: Major
>              Labels: facet, streaming
>         Attachments: SOLR-11836.patch
>
>
> Currently, to retrieve all buckets using the streaming expressions facet 
> function, the {{bucketSizeLimit}} parameter must have a high enough value so 
> that all results will be included. Compare this with the JSON facet API, 
> where you can use {{"limit": -1}} to achieve this. It would help if such a 
> possibility existed.
> [Issue 11236|https://issues.apache.org/jira/browse/SOLR-11236] is related.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to