[ 
https://issues.apache.org/jira/browse/SOLR-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606227#comment-16606227
 ] 

Cassandra Targett edited comment on SOLR-12208 at 9/6/18 6:32 PM:
------------------------------------------------------------------

[~ab], [~noble.paul]: The Ref Guide still references {{INDEX.sizeInBytes}} in 3 
places in 2 files: 2x in {{metrics-history.adoc}} and 1x in 
{{solrcloud-autoscaling-triggers.adoc}}.

ALL of these references need to be changed to {{INDEX.sizeInGB}}, correct?

In {{solrcloud-autoscaling-triggers.adoc}}, the {{aboveBytes}} parameter 
additionally says the value should be entered in bytes, but it will be compared 
to a value in GB. Is that accurate after this metric change?


was (Author: ctargett):
[~ab], [~noble.paul]: The Ref Guide still references {{INDEX.sizeInBytes}} in 3 
places in 2 files: 2x in {{metrics-history.adoc}} and 1x in 
{{solrcloud-autoscaling-triggers.adoc}}.

ALL of these references need to be changed to {{INDEX.sizeInGB}}, correct?

In {{solrcloud-autoscaling-triggers.adoc}}, the {{aboveBytes} parameter 
additionally says the value should be entered in bytes, but it will be compared 
to a value in GB. Is that accurate after this metric change?

> Don't use "INDEX.sizeInBytes" as a tag name in policy calculations
> ------------------------------------------------------------------
>
>                 Key: SOLR-12208
>                 URL: https://issues.apache.org/jira/browse/SOLR-12208
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: AutoScaling
>            Reporter: Andrzej Bialecki 
>            Assignee: Andrzej Bialecki 
>            Priority: Major
>             Fix For: master (8.0), 7.5
>
>         Attachments: SOLR-12208.patch, SOLR-12208.patch, SOLR-12208.patch
>
>
> CORE_IDX and FREEDISK ConditionType reuse this metric name, but they assume 
> the values are expressed in gigabytes. This alone is confusing considering 
> the name of the metric.
> Additionally, it causes conflicts in the simulation framework that would 
> require substantial changes to resolve (ReplicaInfo-s in 
> SimClusterStateProvider keep metric values in their variables, expressed in 
> original units - but then the Policy assumes it can put the values expressed 
> in GB under the same key... hilarity ensues).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to