[
https://issues.apache.org/jira/browse/SOLR-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586213#comment-16586213
]
Christine Poerschke commented on SOLR-10028:
--------------------------------------------
bq. ... alternative patch, I feel it should also work and keeps the test
assertions a bit tighter.
I like the idea of more specific assertions.
If/Since this would check that the correct amount of segments info is returned,
could a further future test perhaps even be then to specifically test that the
returned segment ids are correct?
If/Since {{testSegmentInfosData}} gets the
{code}
+ // Lets just skip this test if number of segments is < 2
+ Assume.assumeTrue(numSegments >= 2);
{code}
then could the earlier
{code}
+ assertTrue("Unexpected number of segment in the index: " + numSegments,
+ numSegments > 0 && numSegments <= 2 );
{code}
in {{beforeClass}} be skipped perhaps?
> SegmentsInfoRequestHandlerTest.testSegmentInfosVersion fails in master
> ----------------------------------------------------------------------
>
> Key: SOLR-10028
> URL: https://issues.apache.org/jira/browse/SOLR-10028
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Tomás Fernández Löbbe
> Priority: Minor
> Attachments: SOLR-10028-alternative.patch, SOLR-10028.patch
>
>
> Failed in Jenkins:
> https://jenkins.thetaphi.de/job/Lucene-Solr-master-Solaris/1092/
> It reproduces consistently in my mac also with the latest master
> (ca50e5b61c2d8bfb703169cea2fb0ab20fd24c6b):
> {code}
> ant test -Dtestcase=SegmentsInfoRequestHandlerTest
> -Dtests.method=testSegmentInfosVersion -Dtests.seed=619B9D838D6F1E29
> -Dtests.slow=true -Dtests.locale=en-AU -Dtests.timezone=America/Manaus
> -Dtests.asserts=true -Dtests.file.encoding=ISO-8859-1
> {code}
> There are similar failures in previous Jenkins builds since last month
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
