Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r211258577
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -40,22 +43,52 @@
private static final Iterator<String> ingredientsCycler =
Iterables.cycle(ingredients).iterator();
private static final String[] names = {"Yaz", "Jazz", "Costa"};
private static final String[] fieldsToRemove = {"_nest_parent_",
"_nest_path_", "_root_"};
+ private static final int sumOfDocsPerNestedDocument = 8;
--- End diff --
I understand we need a filter query here that can be referenced by the
test, but I'm a bit dubious on all these other ones. You may very well have
written the test in such a way that they are necessary at the moment, but lets
consider how to simplify.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]