Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r208507038
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
---
@@ -242,10 +242,10 @@ private void testChildDocNonStoredDVFields() throws
Exception {
"fl", "*,[child parentFilter=\"subject:parentDocument\"]"), test1);
assertJQ(req("q", "*:*", "fq", "subject:\"parentDocument\" ",
- "fl", "subject,[child parentFilter=\"subject:parentDocument\"
childFilter=\"title:foo\"]"), test2);
+ "fl", "id,_childDocuments_,subject,intDvoDefault,[child
parentFilter=\"subject:parentDocument\" childFilter=\"title:foo\"]"), test2);
--- End diff --
Another major difference is that now since child documents are stored as
fields, the user needs to explicitly add them to the list of return fields. I
have no opinion regarding this issue, but this might pose a problem to some use
cases. Perhaps documenting this would be enough?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]