Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r208090646
--- Diff: solr/solrj/src/java/org/apache/solr/common/util/XML.java ---
@@ -208,7 +179,13 @@ public static void escape(String str, Writer out,
String[] escapes) throws IOExc
}
}
+ @FunctionalInterface
public interface Writable {
- void write(Writer w) throws IOException ;
+ void write(Writer w) throws IOException;
+ }
+
+ @FunctionalInterface
+ public interface Escapable<T, U> {
--- End diff --
It's somewhat unusual to have pre-escaped content, I think. Case in point:
the "unescape" method, judging from "find usages" in my IDE, is only used in
tests. Furthermore, I think it's not a good idea to introduce an interface or
class to serve a use case that does not yet exist, nor do we particularly think
it's going to happen.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
